Skip to content

feat: add exception when array is passed for 2nd arg #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2021
Merged

feat: add exception when array is passed for 2nd arg #573

merged 2 commits into from
Apr 2, 2021

Conversation

kiranjd
Copy link
Contributor

@kiranjd kiranjd commented Mar 28, 2021

  • For cases when two or more key values pairs are passed unintentionally as arguements to multiSet.

Summary

resolves #519

Test Plan

As I ran and went through the e2e tests, observed that there are no tests aded for multiSet and multiGet. As this is an exception that is being added to multiSet, would not be ideal to create the tests for the same.

@kiranjd
feat: add exception when array is passed for 2nd arg
b9649d7 
- For cases when two or more key values pairs are passed as arguements to multiSet.

resolves issue#519
tido64
tido64 requested changes Mar 29, 2021
View reviewed changes
tido64
tido64 approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thanks for making all our users' lives easier.

@kiranjd kiranjd closed this Mar 30, 2021
@kiranjd kiranjd reopened this Mar 30, 2021
@kiranjd
Copy link
Contributor Author

kiranjd commented Mar 30, 2021

Sorry, didn't notice it was approved and not merged. Plase merge and close this PR whenever 🙂

@tido64
Copy link
Member

tido64 commented Mar 30, 2021

@krizzu Looks like the Android CI broke because of this:

* What went wrong:
Execution failed for task ':app:stripReleaseDebugSymbols'.
> No version of NDK matched the requested version 21.0.6113669. Versions available locally: 20.1.5948944

Did CircleCI downgrade their VMs or something?

@krizzu krizzu merged commit a6957ba into react-native-async-storage:master Apr 2, 2021
@krizzu
Copy link
Member

krizzu commented Apr 2, 2021

🎉 This PR is included in version 1.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@krizzu krizzu added the released label Apr 2, 2021
@kiranjd kiranjd deleted the feat-multiSet branch April 18, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tido64 tido64 tido64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gracefully handle the case where inputs to multiSet are not of the type Array<Array<String>>
3 participants
@kiranjd @tido64 @krizzu